Fix sandboxed-module not working when using npx#70
Open
tie wants to merge 5 commits intofelixge:masterfrom
Open
Fix sandboxed-module not working when using npx#70tie wants to merge 5 commits intofelixge:masterfrom
tie wants to merge 5 commits intofelixge:masterfrom
Conversation
The requireLike(…).resolve function accepts a path, but CallSite.getFileName(…) returns a URI with file:// scheme. This commit fixes the issue by removing the prefix if origin path starts with file scheme. Since module resolution looks for node_modules in all directories of $PWD, the issue does not arise during development. However, commands that depend on sandboxed-module package would break with MODULE_NOT_FOUND when using npx.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes originPath being a URL instead of a path.
The
requireLike(…).resolvefunction accepts a path, butCallSite.getFileName(…)returns a URI withfile://scheme. This commit fixes the issue by removing the prefix if origin path starts with file scheme.Since module path resolution looks for node_modules in all directories of $PWD, the issue does not arise during development. However, scripts started by
npxthat depend on sandboxed-module package would break with MODULE_NOT_FOUND error.