fix: Some bug fixes #5736
Open
fix: Some bug fixes #5736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew (#175) * Adding python classes for new Feature View type SortedFeatureView * Adding python classes for new Feature View type SortedFeatureView * Adding python classes for new Feature View type SortedFeatureView * fixing formatting * Adding tests and fixing formatting * Adding go class * Adding relevant go class * Adding additional testing * getting rid of dummy entity constants * formatting file to fix linting errors * Adding in new changes to support the new feature view type sortedFeatureView * fixing circular dependency * fixing circular dependency * fixing circular dependency by fixing how things are imported * fixing circular dependency by fixing how things are imported * Fixing linting and missed additions of the SortedFeatureView * fixing formatting issues * fixing formatting issues * fixing failing tests * adding SortedFeatureView to the permission proto * Fixing linting errors * Fixing linting errors * Fixing linting errors * Fixing linting errors * Fixing linting errors * Adding in more changes * Adding changes to the workflow to see if it fixes the build failures * fixing linting issues * Committing PR changes * fixing failing tests * removing setup tools from GHA unit_tests workflow * Modifying go class and adding back build addition to workflow * removing cast * changing value type field for SortedFeatureViewSortKeyModel * changing value type field for SortedFeatureViewSortKeyModel * modified ensure_valid method in SortedFeatureView * Added more changes based on PR comments
* add logging to CachingRegistry * chore: formatting * fix: add more logs to find what line is bringing down thread * fix: delete added coverage files * fix: switch to time.sleep in refresh thread * fix: remove verbose logging and add exception handling
feat: Adding range query request and response proto
…#186) * fix: add SortedFeatureView to base registry deserialize values method * fix linting
* Adding create table functionality for sorted feature view * removing repitition while adding sort key names * adding timestamp field consideration into sort key * formatting
…#188) * adding SortedFeatureView custom exception type * adding delete for sortedFeatureView * making changes to http end-point * formatting and reverting back a change
…or sorted feature view
… online store (#191) Co-authored-by: Bhargav Dodla <[email protected]>
fix: Make Sorted feature view hashable
* added integration tests * Remove accidentally committed feast binary * adding ignore build integration --------- Co-authored-by: Manisha Sudhir <[email protected]>
* ttl changes * fix linting error * fixing the tests * updated the threading logic * fixing a typo * fix linting error * cleanup * cleanup * reformatting * pull max_evnts from feature view tags * fix import * Refactoring and added more unit tests * fix: formatting * formatting * fix tests * formatting * formatting * updated based on the materilaization changes * formatting * formatting * added valkey changes * bug fix * Address review comments * type * fix typo * formatting * fix failing unit tests * update tests * fix: Count ttl command * bug fix * Update sdk/python/feast/infra/online_stores/redis.py Co-authored-by: kpulipati29 <[email protected]> * address review comments * lint fixes * fix: Enable event time ttl * fix: Use event timestamp to set ttl in redis hash * fix: linting * fix: imports * fix: imports * fix: Small fix * fix: Small fix * fix: exception handling and some cleanup * fix: formatting fix * fix: lint fix * fix: Reduce batch size * fix: reduce batch size * fix: dont expire if ttl is zerp --------- Co-authored-by: vbhagwat <[email protected]> Co-authored-by: Krishna mohan Pulipati <[email protected]> Co-authored-by: kpulipati29 <[email protected]>
Collaborator
|
@kpulipati29 Hi, did you send the PR to the wrong repo? |
added 10 commits
December 1, 2025 10:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Misc