Skip to content

Fix output in CLI for authenticated file download #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fanuware merged 1 commit into from
Aug 7, 2025
Merged

Fix output in CLI for authenticated file download #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,12 @@ Authenticated file download

```bash
fync-get <URL>
fync-get --update <URL>
```

For example, you can download using **Bearer** or **Basic Authentication**.

```bash
fync-get https://httpbin.org/bearer
fync-get https://httpbin.org/basic-auth/test-user/test-password
```
9 changes: 6 additions & 3 deletions src/fync/get.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ def url_request(url, opener):
if not filename:
parsed_url = urllib.parse.urlparse(url)
filename = os.path.basename(parsed_url.path)

if not filename:
filename = 'download'
filename_to_use = filename
postfix_num = 1
while os.path.exists(filename_to_use):
Expand All @@ -40,9 +41,11 @@ def url_request(url, opener):
shutil.move(temporary_filename, filename_to_use)
return filename_to_use
except urllib.error.URLError as e:
print(f'Error downloading {url}: {e}')
print(f'- Error downloading {url}: {e}')
except PermissionError as e:
print(f'Error Permission handling: {e}')
print(f'- Error downloading {url}: {e}')
except ValueError as e:
print(f'- Error downloading {url}: {e}')
finally:
if os.path.exists(temp_file.name):
os.unlink(temp_file.name)
Expand Down