Support passing images to factorial-agent#29
Merged
rogercampos merged 1 commit intomainfrom Nov 10, 2025
Merged
Conversation
rogercampos
force-pushed
the
feature/image-support
branch
from
5ceef1e to
97eac07
Compare
focusshifter
reviewed
Nov 6, 2025
lib/ai/types/image_part.rb
Outdated
|
|
||
| sig { returns(T::Hash[Symbol, String]) } | ||
| def as_json | ||
| encoded = Base64.strict_encode64(image_data) |
There was a problem hiding this comment.
I don't think it will bite us ever, but still propose using image_data.b here to always treat stringified data as binary.
focusshifter
previously approved these changes
Nov 6, 2025
Contributor
Author
i don't need that now, but i can also add it if you want. We need to do some sanitization on the input file before giving it to the llm (like rezie if big dimensions or converting pdfs) so it's better for me to pass the blob. |
rogercampos
force-pushed
the
feature/image-support
branch
from
97eac07 to
3c7aa61
Compare
Contributor
Author
|
added support for urls now |
rogercampos
force-pushed
the
feature/image-support
branch
from
3c7aa61 to
088fce5
Compare
oriolgual
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for images forwarding to factorial-agent. Only blobs are supported, not remote urls