feat(tags): add right prop to all tags#3511
Closed
factmarc10010 wants to merge 2 commits intomainfrom
Closed
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
✅ No New Circular DependenciesNo new circular dependencies detected. Current count: 0 |
Contributor
📦 Alpha Package Version PublishedUse Use |
Contributor
🔍 Visual review for your branch is published 🔍Here are the links to: |
Contributor
sauldom102
reviewed
Feb 26, 2026
Comment on lines
+35
to
+39
| /** | ||
| * Content to render on the right side of the tag (e.g. icon or action) | ||
| */ | ||
| right?: ReactNode | ||
|
|
Collaborator
There was a problem hiding this comment.
We shouldn't have such a generic prop to add any content here, we should discuss the use case and adapt the component or create a new one in case we need it to cover that but not making this one too flexible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add optional
rightprop to all F0 tag components so consumers can render content on the right side of tags (e.g. icons, remove buttons) in the same way BaseTag already supports. The F0Tag router component also supportsrightby forwarding it via the tag variant props.Screenshots (if applicable)
Implementation details
right?: ReactNodeprop; it was not exposed on the public tag components.right?: ReactNodeto props and pass it through to BaseTag. This enables right content for F0TagPerson, F0TagCompany, and F0TagTeam.right?: ReactNodeto their types and pass it to BaseTag.right?: ReactNodeto their types and forward it to F0TagAvatar.Tag): No code changes. It already spreads the tag object (e.g.{ type: "person", name: "...", right: ... }) to the underlying component, sorightis supported for all variants once each component accepts it.All new props are optional and backward compatible.