chore: Update packages, remove resolved Microsoft.OpenApi pin - #2186
Merged
Conversation
Microsoft.AspNetCore.OpenApi 10.0.10 pulled in Microsoft.OpenApi 2.0.0, vulnerable per GHSA-v5pm-xwqc-g5wc, so an explicit Microsoft.OpenApi 2.8.0 override was pinned as a workaround in tools/sse-server. Microsoft.AspNetCore.OpenApi 10.0.11 now declares a native dependency floor of Microsoft.OpenApi >= 2.7.5 (already patched), making the manual override unnecessary. Bump to 10.0.11 and drop the override.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
DaveSkender
marked this pull request as ready for review
August 17, 2026 13:14
Contributor
|
|
Microsoft.OpenApi pin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tools/Directory.Packages.propsandtools/sse-server/Test.SseServer.csprojcarry an explicit, self-labeled "temp pin":Microsoft.AspNetCore.OpenApi10.0.10's own manifest requiresMicrosoft.OpenApi 2.0.0, which is vulnerable per GHSA-v5pm-xwqc-g5wc (a small OpenAPI document with a circular schema reference can crash parsing via stack overflow). The override pin worked around that by forcing a patchedMicrosoft.OpenApiversion directly. The.csprojcopy of the comment was also already stale, still referencing "v10.0.9" after a prior version bump.Why prioritized
Found directly in the codebase while surveying the org for maintenance work — a self-documented "temp pin" is exactly the kind of workaround this routine is meant to catch and clear once the underlying reason for it goes away. Verified against the live NuGet package data (see below) that the workaround is no longer necessary. Small, single-project, single-intent change (2 source files + the generated lock file). No open PR or branch in this repository touched these files.
What changed
tools/Directory.Packages.props: bumpedMicrosoft.AspNetCore.OpenApiandMicrosoft.Extensions.ApiDescription.Serverfrom10.0.10→10.0.11, and removed the now-unnecessaryMicrosoft.OpenApioverride and its comment.tools/sse-server/Test.SseServer.csproj: removed the correspondingMicrosoft.OpenApiPackageReferenceoverride and its (already-stale) comment.tools/sse-server/packages.lock.json: regenerated viadotnet restoreto reflect the new resolution —Microsoft.OpenApinow resolves transitively to2.7.5, versus the previously pinned2.8.0; both are patched.Microsoft.AspNetCore.OpenApi10.0.11's own nuspec now declares itsMicrosoft.OpenApidependency as[2.7.5, 3.0.0)— i.e., the fix moved upstream, so this project's manual override is redundant and actively stale (it hardcoded a single version rather than tracking the floor).How validated
Microsoft.AspNetCore.OpenApi10.0.11 exists and its nuspec dependency range forMicrosoft.OpenApiis[2.7.5, 3.0.0)(2.7.5 is GHSA-v5pm-xwqc-g5wc's patched floor), versus 10.0.10's unpinnedMicrosoft.OpenApi 2.0.0(vulnerable).dotnet restore --force-evaluateintools/sse-serverregeneratedpackages.lock.jsoncleanly; the transitiveMicrosoft.OpenApientry resolved to2.7.5.dotnet restore --locked-mode(matching CI'sRestoreLockedModegate) succeeds against the regenerated lock file.dotnet build --configuration Release --property:ContinuousIntegrationBuild=true -warnAsError(matching this repo's CI build step) succeeds with 0 warnings/errors, including the build-time OpenAPI document generation step (GenerateOpenApiDocuments) that exercises the newMicrosoft.OpenApiversion directly.dotnet list package --vulnerable --include-transitiveonTest.SseServerreports no vulnerable packages from the current sources.Limitations / follow-up
tools/sse-server's CI job (test-integration.yml) is gatedif: !github.event.pull_request.draft, so it won't run automatically while this PR stays in draft; the local restore/build/lock-file validation above covers the same surface it would exercise.tools/pin; no other project in this repository referencesMicrosoft.OpenApidirectly.This pull request was triggered via an automated maintenance routine.
Generated by Claude Code