Bump websocket-driver 0.7.4 -> 0.7.5 in vrs/website - #265
Closed
kongchen1992 wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@kongchen1992 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116379479. |
Summary: `websocket-driver@0.7.4` in `arvr/libraries/vrs/website/yarn.lock` is flagged by [CVE-2026-54466](https://www.internalfb.com/intern/vulnerability_management/vulnerabilities/CVE-2026-54466) (CWE-130, Improper Handling of Length Parameter Inconsistency, CVSS >= 7). The fixed version is 0.7.5. The VM auto-remediator (`VMRemediatorTPLUpgrader`) already tried and failed on this asset — it fed the asset XID to the upgrader as if it were a path and bailed with `Invalid value: Project path 'arvr/libraries/vrs/website/yarn.lock#pkg:npm/websocket-driver@..' does not exist.` So this is the manual bump. `websocket-driver` is transitive-only here, pulled in twice via `webpack-dev-server`: - `sockjs@0.3.24` -> `websocket-driver@^0.7.4` - `faye-websocket@0.11.4` -> `websocket-driver@>=0.5.1` Both ranges already admit 0.7.5, so the lockfile is the only place the version actually moves. Per PiotrBrzyski's review, this also adds a `resolutions` floor in `package.json` so the fix survives a future re-resolve — see the test plan for a concrete case where the lockfile alone would silently regress. That matches what the other docusaurus sites in fbsource do for this exact package (`fbcode/whatsapp/elp/website` uses `^0.7.5`, `fbcode/buck2/website` uses `>=0.7.5 <0.8.0`), and the file already carries six `resolutions` entries of the same shape. 0.7.5 keeps the same dependency set (`http-parser-js`, `safe-buffer`, `websocket-extensions`), so no other lockfile entries move. Reviewed By: PiotrBrzyski Differential Revision: D116379479
kongchen1992
force-pushed
the
export-D116379479
branch
from
August 18, 2026 16:10
1837115 to
b0434a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
websocket-driver@0.7.4inarvr/libraries/vrs/website/yarn.lockis flagged byCVE-2026-54466
(CWE-130, Improper Handling of Length Parameter Inconsistency, CVSS >= 7). The fixed
version is 0.7.5.
The VM auto-remediator (
VMRemediatorTPLUpgrader) already tried and failed on thisasset — it fed the asset XID to the upgrader as if it were a path and bailed with
Invalid value: Project path 'arvr/libraries/vrs/website/yarn.lock#pkg:npm/websocket-driver@..' does not exist.So this is the manual bump.
websocket-driveris transitive-only here, pulled in twice viawebpack-dev-server:sockjs@0.3.24->websocket-driver@^0.7.4faye-websocket@0.11.4->websocket-driver@>=0.5.1Both ranges already admit 0.7.5, so the lockfile is the only place the version actually
moves. Per PiotrBrzyski's review, this also adds a
resolutionsfloor inpackage.jsonsothe fix survives a future re-resolve — see the test plan for a concrete case where the
lockfile alone would silently regress. That matches what the other docusaurus sites in
fbsource do for this exact package (
fbcode/whatsapp/elp/websiteuses^0.7.5,fbcode/buck2/websiteuses>=0.7.5 <0.8.0), and the file already carries sixresolutionsentries of the same shape.0.7.5 keeps the same dependency set (
http-parser-js,safe-buffer,websocket-extensions), so no other lockfile entries move.Reviewed By: PiotrBrzyski
Differential Revision: D116379479