Skip to content

fix unexpected ValueError #1270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix unexpected ValueError #1270

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
46ef730
fix unexpected ValueError
jimmieliu Nov 6, 2022
ec03187
Merge branch 'main' into patch-1
ankitade Apr 5, 2023
0529c08
Merge branch 'main' into patch-1
jimmieliu Apr 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mmf/common/registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,8 +632,8 @@ def get(cls, name, default=None, no_warning=False):

if (
"writer" in cls.mapping["state"]
and value == default
and no_warning is False
and type(value) == type(default) and value == default
):
cls.mapping["state"]["writer"].warning(
"Key {} is not present in registry, returning default value "
Expand Down