Add service for Slurm topology collection - #175
Open
giongto35 wants to merge 1 commit into
Open
Conversation
CI CommandsThe following CI workflows run automatically on every push and pull request:
The following commands can be used by maintainers to trigger additional tests that require access to secrets:
|
giongto35
force-pushed
the
thanhnh/scontrol-topology-scuba-service
branch
from
August 14, 2026 05:44
30496b1 to
e7694dd
Compare
Summary: Package and configure scontrol_topology as a single-node systemd service that collects and publishes Slurm topology every 60 seconds. Add Debian packaging and operator documentation while leaving exporter-specific routing in deployment configuration. Test Plan: Static checks: git diff --check; black --check and flake8 on gcm/tests/test_scontrol_topology.py; TOML, Python syntax, systemd-analyze, and Debian packaging verification. End to end: deployed the GCM build to a development Slurm cluster, ran a live one-shot topology collection through the configured telemetry pipeline, and confirmed fresh rows in the target dataset with the expected topology fields and node counts.
giongto35
force-pushed
the
thanhnh/scontrol-topology-scuba-service
branch
from
August 14, 2026 06:20
e7694dd to
7ab5e62
Compare
luccabb
approved these changes
Aug 14, 2026
Yash0270
approved these changes
Aug 14, 2026
Yash0270
reviewed
Aug 14, 2026
|
|
||
| ## Overview | ||
|
|
||
| Collects Slurm topology from `scontrol show topo` every 60 seconds. Run one |
Contributor
There was a problem hiding this comment.
every 60sec is really aggressive? topology changes happens once an hour on avg.
Contributor
There was a problem hiding this comment.
could we make it once every 5mins
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Package and configure
scontrol_topologyas a single-node systemd servicethat collects and publishes Slurm topology every 60 seconds.
This also adds Debian packaging and operator documentation. The collector
already existed, but it was not packaged or scheduled as a service.
Test Plan
git diff --check— passed.black --check gcm/tests/test_scontrol_topology.py— passed.flake8 gcm/tests/test_scontrol_topology.py— passed.config.tomland verified thescontrol_topologysettings — passed.scontrol_topology.servicewithsystemd-analyze verify— passed.scontrol_topology.service— passed.scontrol show topo.topology fields and node counts.