[WIP]: Deterministic Entropy Coding Cross-Architecture #95
[WIP]: Deterministic Entropy Coding Cross-Architecture #95jbrough wants to merge 9 commits intofacebookresearch:mainfrom
Conversation
|
Hi @jbrough! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Please anyone feel free to help with this :)
tested encoding on OSX and decoding on Linux AMD:
% of N second chunks decoded and playable without errors (Binary search failed, end of stream etc).
encodec vs PR branch
1 second: 90% vs 98%
10 second: 60% vs 90%
30 second: 14% vs 85%
60 second: 0% vs 75%
This is a bit skewed as at 60 secs my test audio had only 4 chunks and the PR branch is failing on a particular region of audio (is it related to dynamics?). So it's probably much better than 75%.
Also, I should have read the comments -
but having tried it Im not sure that works.