This repository was archived by the owner on Jan 13, 2022. It is now read-only.
set_ubuntu.sh works on 17.10, Dockerfile builds#62
Open
michaelnugent wants to merge 1 commit intofacebookarchive:masterfrom
Open
set_ubuntu.sh works on 17.10, Dockerfile builds#62michaelnugent wants to merge 1 commit intofacebookarchive:masterfrom
michaelnugent wants to merge 1 commit intofacebookarchive:masterfrom
Conversation
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@jteller has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows Beringei with a known good version of the upstream files. setup_ubuntu.sh works and the dockerfile builds cleanly. I've taken the setup TG is using and wrapped it in #ifdef's to peg the versions.