Use correct base class for NativeReactNativeFeatureFlags #54046
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83815509. |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 3, 2025
) Summary: Changelog: [Internal] Per documentation the base class to extend from is the non `JSI` one: https://reactnative.dev/docs/the-new-architecture/pure-cxx-modules#3-write-the-native-code Differential Revision: D83815509
christophpurrer
force-pushed
the
export-D83815509
branch
from
40f3ab1 to
2d3c90f
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 3, 2025
) Summary: Changelog: [Internal] Per documentation the base class to extend from is the non `JSI` one: https://reactnative.dev/docs/the-new-architecture/pure-cxx-modules#3-write-the-native-code Reviewed By: rubennorte Differential Revision: D83815509
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 3, 2025
) Summary: Changelog: [Internal] Per documentation the base class to extend from is the non `JSI` one: https://reactnative.dev/docs/the-new-architecture/pure-cxx-modules#3-write-the-native-code Reviewed By: rubennorte Differential Revision: D83815509
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 3, 2025
) Summary: Changelog: [Internal] Per documentation the base class to extend from is the non `JSI` one: https://reactnative.dev/docs/the-new-architecture/pure-cxx-modules#3-write-the-native-code Reviewed By: rubennorte Differential Revision: D83815509
christophpurrer
force-pushed
the
export-D83815509
branch
from
2d3c90f to
0f9a35f
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 3, 2025
) Summary: Changelog: [Internal] Per documentation the base class to extend from is the non `JSI` one: https://reactnative.dev/docs/the-new-architecture/pure-cxx-modules#3-write-the-native-code Reviewed By: rubennorte Differential Revision: D83815509
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 3, 2025
) Summary: Changelog: [Internal] Per documentation the base class to extend from is the non `JSI` one: https://reactnative.dev/docs/the-new-architecture/pure-cxx-modules#3-write-the-native-code Reviewed By: rubennorte Differential Revision: D83815509
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 3, 2025
) Summary: Changelog: [Internal] Per documentation the base class to extend from is the non `JSI` one: https://reactnative.dev/docs/the-new-architecture/pure-cxx-modules#3-write-the-native-code Reviewed By: rubennorte Differential Revision: D83815509
christophpurrer
force-pushed
the
export-D83815509
branch
from
0f9a35f to
41bab04
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 3, 2025
) Summary: Changelog: [Internal] Per documentation the base class to extend from is the non `JSI` one: https://reactnative.dev/docs/the-new-architecture/pure-cxx-modules#3-write-the-native-code Reviewed By: rubennorte Differential Revision: D83815509
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 3, 2025
) Summary: Changelog: [Internal] Per documentation the base class to extend from is the non `JSI` one: https://reactnative.dev/docs/the-new-architecture/pure-cxx-modules#3-write-the-native-code Reviewed By: rubennorte Differential Revision: D83815509
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 4, 2025
) Summary: Changelog: [Internal] Per documentation the base class to extend from is the non `JSI` one: https://reactnative.dev/docs/the-new-architecture/pure-cxx-modules#3-write-the-native-code Reviewed By: rubennorte Differential Revision: D83815509
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 4, 2025
) Summary: Changelog: [Internal] Per documentation the base class to extend from is the non `JSI` one: https://reactnative.dev/docs/the-new-architecture/pure-cxx-modules#3-write-the-native-code Reviewed By: rubennorte Differential Revision: D83815509
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 4, 2025
) Summary: Changelog: [Internal] Per documentation the base class to extend from is the non `JSI` one: https://reactnative.dev/docs/the-new-architecture/pure-cxx-modules#3-write-the-native-code Reviewed By: rubennorte Differential Revision: D83815509
christophpurrer
force-pushed
the
export-D83815509
branch
from
41bab04 to
993d2d1
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 4, 2025
) Summary: Changelog: [Internal] Per documentation the base class to extend from is the non `JSI` one: https://reactnative.dev/docs/the-new-architecture/pure-cxx-modules#3-write-the-native-code Reviewed By: rubennorte Differential Revision: D83815509
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 4, 2025
) Summary: Changelog: [Internal] Per documentation the base class to extend from is the non `JSI` one: https://reactnative.dev/docs/the-new-architecture/pure-cxx-modules#3-write-the-native-code Reviewed By: rubennorte Differential Revision: D83815509
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 4, 2025
) Summary: Changelog: [Internal] Per documentation the base class to extend from is the non `JSI` one: https://reactnative.dev/docs/the-new-architecture/pure-cxx-modules#3-write-the-native-code Reviewed By: rubennorte Differential Revision: D83815509
) Summary: Changelog: [Internal] Per documentation the base class to extend from is the non `JSI` one: https://reactnative.dev/docs/the-new-architecture/pure-cxx-modules#3-write-the-native-code Reviewed By: rubennorte Differential Revision: D83815509
christophpurrer
force-pushed
the
export-D83815509
branch
from
993d2d1 to
2c06985
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 4, 2025
) Summary: Changelog: [Internal] Per documentation the base class to extend from is the non `JSI` one: https://reactnative.dev/docs/the-new-architecture/pure-cxx-modules#3-write-the-native-code Reviewed By: rubennorte Differential Revision: D83815509
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 4, 2025
) Summary: Changelog: [Internal] Per documentation the base class to extend from is the non `JSI` one: https://reactnative.dev/docs/the-new-architecture/pure-cxx-modules#3-write-the-native-code Reviewed By: rubennorte Differential Revision: D83815509
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 4, 2025
) Summary: Changelog: [Internal] Per documentation the base class to extend from is the non `JSI` one: https://reactnative.dev/docs/the-new-architecture/pure-cxx-modules#3-write-the-native-code Reviewed By: rubennorte Differential Revision: D83815509
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Per document the base class to extend from is the non
JSIone:https://reactnative.dev/docs/the-new-architecture/pure-cxx-modules#3-write-the-native-code
Differential Revision: D83815509