Fix namespace package finding #1242
Open
+180
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This diff replaces the requirement to copy paths around to get their `ModuleStyle` with a function that quickly returns it. Differential Revision: D83847656
Summary: This diff pushes the conversion of a `FindResult` to a `ModulePath` from within `find_module_components` up to `find_module`. This is necessary because `NamespacePackage`s will need special handling, since they can be overridden at any point by a higher priority find result later in the module find logic. In the next diff, we check for namespace modules and handle them. Differential Revision: D83847655
Summary: This diff mostly includes updates to an interface and the affected tests. This diff stores found namespace results, and returns them yfrom the end of `find_import_filtered` if no higher-priority `FindResult` is found sooner. This is because results in `search-path`, `typeshed`, and `site-package-path` can override a previously found namespace package if they contain a file or regular package match, and we shouldn't just early return from a single find component if we find a namespace result. Differential Revision: D83847654
|
@connernilsen has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83847654. |
|
@connernilsen has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83847654. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff mostly includes updates to an interface and the affected tests.
This diff stores found namespace results, and returns them yfrom the end of
find_import_filteredif no higher-priorityFindResultis found sooner. This is because results insearch-path,typeshed, andsite-package-pathcan override a previously found namespace package if they contain a file or regular package match, and we shouldn't just early return from a single find component if we find a namespace result.Differential Revision: D83847654