Open
Conversation
grzmiel
approved these changes
Jan 18, 2023
|
@grzmiel has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
grzmiel
suggested changes
Jan 19, 2023
grzmiel
left a comment
There was a problem hiding this comment.
You have to add those entries to RevokeRequest as well.
idb/grpc/client.py
Outdated
| Permission.LOCATION: RevokeRequest.LOCATION, | ||
| Permission.NOTIFICATION: RevokeRequest.NOTIFICATION, | ||
| Permission.MICROPHONE: RevokeRequest.MICROPHONE, | ||
| Permission.CALENDAR: ApproveRequest.CALENDAR, |
| LOCATION = 4; | ||
| NOTIFICATION = 5; | ||
| MICROPHONE = 6; | ||
| CALENDAR = 7; |
There was a problem hiding this comment.
Add the same entries in the RevokeRequest below
|
Do you have any new about this PR? |
|
These are very useful changes, what's stopping you from making a merge of changes at this point? |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
There have been several new user permissions introduced over the last couple of major iOS versions. This change adds the missing permissions that may be modified via existing TCC.db queries.
Notably, the "Health" permission is missing since it requires modification to a standalone
healthdb.sqlitedatabase. This will be implemented in a future PR.The following permissions have been added:
Test Plan
idb approve -hGrant any/all of the introduced permissions for a valid bundle ID:
idb approve com.example.app calendarVerify the supplied permissions have been successfully granted for the bundle ID
Revoke any/all of the introduced permissions for a valid bundle ID:
idb revoke com.example.app calendarVerify the supplied permissions have been successfully revoked for the bundle ID
Related PRs