Skip to content

Teach implVecElemLval to emit operations better suited for AArch64 #9658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −0
Open

Teach implVecElemLval to emit operations better suited for AArch64 #9658

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions hphp/runtime/vm/jit/irlower-minstr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -904,6 +904,11 @@ irlower::LvalPtrs implVecElemLval(IRLS& env, Vreg rarr,
v << lea{ridx[ridx * 8], ridx_times_9};
auto const type_offset = VanillaVec::entriesOffset() + offsetof(UnalignedTypedValue, m_type);
auto const data_offset = VanillaVec::entriesOffset() + offsetof(UnalignedTypedValue, m_data);
if (arch() == Arch::ARM) {
auto new_base = v.makeReg();
v << lea{rarr[ridx_times_9], new_base};
return {new_base + type_offset, new_base + data_offset};
}
return {rarr[ridx_times_9] + type_offset, rarr[ridx_times_9] + data_offset};
} else {
// See PackedBlock::LvalAt for an explanation of this math.
Expand Down