more fault tolerant mast benchmarking #4362
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The MAST-calling jobs now have a retry count s.t. they are restarted if they fail e.g. due to manifold errors. Additionally, I have added a timeout of 12 hours s.t. a job that gets stuck fails after that time. This of course has the downside, that if a job is meant to take this long it will be failed, I'd say we should not really have any jobs like this, though, if we properly parallelize, no? Our nightlies for example take 5 hours at most (which is already a little unnecessarily long, given that we can parallelize things basically ad infinitum, no?) Differential Revision: D81128135
meta-cla
bot
added
the
CLA Signed
|
@SamuelGabriel has exported this pull request. If you are a Meta employee, you can view the originating diff in D81128135. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4362 +/- ##
=======================================
Coverage 96.26% 96.26%
=======================================
Files 564 564
Lines 57914 57916 +2
=======================================
+ Hits 55751 55753 +2
Misses 2163 2163 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The MAST-calling jobs now have a retry count s.t. they are restarted if they fail e.g. due to manifold errors. Additionally, I have added a timeout of 12 hours s.t. a job that gets stuck fails after that time.
This of course has the downside, that if a job is meant to take this long it will be failed, I'd say we should not really have any jobs like this, though, if we properly parallelize, no? Our nightlies for example take 5 hours at most (which is already a little unnecessarily long, given that we can parallelize things basically ad infinitum, no?)
Differential Revision: D81128135