Move relativize functions out of statstools to avoid circular dependency in imports #4341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@shrutipatel31 has exported this pull request. If you are a Meta employee, you can view the originating diff in D83095707. |
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Sep 24, 2025
…ncy in imports (facebook#4341) Summary: To resolve a circular dependency between `ax.core` and `statstools`, this diff moves the `relativize`, `unrelativize`, and `relativize_data` functions out of statstools. The `Data` class now provides a relativized method to replace relativize_data, and all relevant imports, dependencies, and unit tests have been updated accordingly. Differential Revision: D83095707
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4341 +/- ##
=======================================
Coverage 96.26% 96.26%
=======================================
Files 564 566 +2
Lines 58122 58179 +57
=======================================
+ Hits 55951 56006 +55
- Misses 2171 2173 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Sep 24, 2025
…ncy in imports (facebook#4341) Summary: To resolve a circular dependency between `ax.core` and `statstools`, this diff moves the `relativize`, `unrelativize`, and `relativize_data` functions out of statstools. The `Data` class now provides a relativized method to replace relativize_data, and all relevant imports, dependencies, and unit tests have been updated accordingly. Differential Revision: D83095707
shrutipatel31
force-pushed
the
export-D83095707
branch
from
8c0b2ea to
2cc3c68
Compare
|
@shrutipatel31 has exported this pull request. If you are a Meta employee, you can view the originating diff in D83095707. |
shrutipatel31
force-pushed
the
export-D83095707
branch
from
2cc3c68 to
571c3bf
Compare
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Sep 24, 2025
…ncy in imports (facebook#4341) Summary: To resolve a circular dependency between `ax.core` and `statstools`, this diff moves the `relativize`, `unrelativize`, and `relativize_data` functions out of statstools. The `Data` class now provides a relativized method to replace relativize_data, and all relevant imports, dependencies, and unit tests have been updated accordingly. Differential Revision: D83095707
|
@shrutipatel31 has exported this pull request. If you are a Meta employee, you can view the originating diff in D83095707. |
shrutipatel31
force-pushed
the
export-D83095707
branch
from
571c3bf to
206e009
Compare
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Sep 25, 2025
…ncy in imports (facebook#4341) Summary: To resolve a circular dependency between `ax.core` and `statstools`, this diff moves the `relativize`, `unrelativize`, and `relativize_data` functions out of statstools. The `Data` class now provides a relativized method to replace relativize_data, and all relevant imports, dependencies, and unit tests have been updated accordingly. Differential Revision: D83095707
|
@shrutipatel31 has exported this pull request. If you are a Meta employee, you can view the originating diff in D83095707. |
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Sep 25, 2025
…ncy in imports (facebook#4341) Summary: To resolve a circular dependency between `ax.core` and `statstools`, this diff moves the `relativize`, `unrelativize`, and `relativize_data` functions out of statstools. The `Data` class now provides a relativized method to replace relativize_data, and all relevant imports, dependencies, and unit tests have been updated accordingly. Differential Revision: D83095707
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Sep 25, 2025
…ncy in imports (facebook#4341) Summary: To resolve a circular dependency between `ax.core` and `statstools`, this diff moves the `relativize`, `unrelativize`, and `relativize_data` functions out of statstools. The `Data` class now provides a relativized method to replace relativize_data, and all relevant imports, dependencies, and unit tests have been updated accordingly. Differential Revision: D83095707
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Sep 25, 2025
…ncy in imports (facebook#4341) Summary: To resolve a circular dependency between `ax.core` and `statstools`, this diff moves the `relativize`, `unrelativize`, and `relativize_data` functions out of statstools. The `Data` class now provides a relativized method to replace relativize_data, and all relevant imports, dependencies, and unit tests have been updated accordingly. Differential Revision: D83095707
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Sep 25, 2025
…ncy in imports (facebook#4341) Summary: To resolve a circular dependency between `ax.core` and `statstools`, this diff moves the `relativize`, `unrelativize`, and `relativize_data` functions out of statstools. The `Data` class now provides a relativized method to replace relativize_data, and all relevant imports, dependencies, and unit tests have been updated accordingly. Differential Revision: D83095707
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Sep 25, 2025
…ncy in imports (facebook#4341) Summary: To resolve a circular dependency between `ax.core` and `statstools`, this diff moves the `relativize`, `unrelativize`, and `relativize_data` functions out of statstools. The `Data` class now provides a relativized method to replace relativize_data, and all relevant imports, dependencies, and unit tests have been updated accordingly. Differential Revision: D83095707
shrutipatel31
force-pushed
the
export-D83095707
branch
from
206e009 to
2faecab
Compare
|
@shrutipatel31 has exported this pull request. If you are a Meta employee, you can view the originating diff in D83095707. |
shrutipatel31
force-pushed
the
export-D83095707
branch
from
2faecab to
c5577d5
Compare
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Oct 1, 2025
…ncy in imports (facebook#4341) Summary: To resolve a circular dependency between `ax.core` and `statstools`, this diff moves the `relativize`, `unrelativize`, and `relativize_data` functions out of statstools. The `Data` class now provides a relativized method to replace relativize_data, and all relevant imports, dependencies, and unit tests have been updated accordingly. Reviewed By: mgarrard Differential Revision: D83095707
|
@shrutipatel31 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83095707. |
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Oct 1, 2025
…ncy in imports (facebook#4341) Summary: To resolve a circular dependency between `ax.core` and `statstools`, this diff moves the `relativize`, `unrelativize`, and `relativize_data` functions out of statstools. The `Data` class now provides a relativized method to replace relativize_data, and all relevant imports, dependencies, and unit tests have been updated accordingly. Reviewed By: mgarrard Differential Revision: D83095707
shrutipatel31
force-pushed
the
export-D83095707
branch
from
c5577d5 to
db53263
Compare
…ncy in imports (facebook#4341) Summary: To resolve a circular dependency between `ax.core` and `statstools`, this diff moves the `relativize`, `unrelativize`, and `relativize_data` functions out of statstools. The `Data` class now provides a relativized method to replace relativize_data, and all relevant imports, dependencies, and unit tests have been updated accordingly. Reviewed By: mgarrard Differential Revision: D83095707
shrutipatel31
force-pushed
the
export-D83095707
branch
from
db53263 to
63ce387
Compare
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Oct 1, 2025
…ncy in imports (facebook#4341) Summary: To resolve a circular dependency between `ax.core` and `statstools`, this diff moves the `relativize`, `unrelativize`, and `relativize_data` functions out of statstools. The `Data` class now provides a relativized method to replace relativize_data, and all relevant imports, dependencies, and unit tests have been updated accordingly. Reviewed By: mgarrard Differential Revision: D83095707
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: To resolve a circular dependency between
ax.coreandstatstools, this diff moves therelativize,unrelativize, andrelativize_datafunctions out of statstools. TheDataclass now provides a relativized method to replace relativize_data, and all relevant imports, dependencies, and unit tests have been updated accordingly.Differential Revision: D83095707