API to add/disable parameters #4228
Open
+700
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Add two properties to `Parameter`: 1. `backfill_value` - used for parameters added to experiments that already have run trials. Specifies the backfill value to use for trials that have already run. 2. `default_value` - used for parameters disabled in experiments that already have run trials. Specified the default value to use in modeling for future trials. Reviewed By: lena-kashtelyan Differential Revision: D79260975
Summary: In `Experiment` add two methods `add_parameters_to_search_space` and `disable_parameters_in_search_space`. In `Adapter._process_and_transform_data` check if the experiment's search space has been updated and update the adapter's search space and model space. Use `backfill_values` for `FillMissingParameters` transform. In `GenerationNode._determine_fixed_features_from_node` check for any disabled parameters. Add their `default_value` as fixed features. Reviewed By: lena-kashtelyan Differential Revision: D79263457
Summary: Fix remaining Pyre errors in experiment.py Reviewed By: mpolson64, lena-kashtelyan Differential Revision: D80579073
Summary: Client API to expose SS updates. Wrappers for `experiment.add_parameters_to_search_space` and `experiment.disable_parameters_in_search_space`. Differential Revision: D80633169
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D80633169 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4228 +/- ##
========================================
Coverage 96.12% 96.12%
========================================
Files 566 566
Lines 57556 57783 +227
========================================
+ Hits 55324 55544 +220
- Misses 2232 2239 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Client API to expose SS updates. Wrappers for
experiment.add_parameters_to_search_spaceandexperiment.disable_parameters_in_search_space.Differential Revision: D80633169