Disallow null or inf values in the mean column of Data & MapData #4045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This is an alternative to D77892970 that moves the check for null / inf values up from experiment into the data constructors. This way, the errors would be raised earlier, including directly in metric fetchin, which is generally favorable. Reviewed By: esantorella Differential Revision: D78122461
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78122461 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4045 +/- ##
=======================================
Coverage 96.03% 96.03%
=======================================
Files 564 564
Lines 56304 56321 +17
=======================================
+ Hits 54071 54090 +19
+ Misses 2233 2231 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This is an alternative to D77892970 that moves the check for null / inf values up from experiment into the data constructors. This way, the errors would be raised earlier, including directly in metric fetchin, which is generally favorable.
Reviewed By: esantorella
Differential Revision: D78122461