Conversation
trouveyre
approved these changes
Oct 7, 2025
Contributor
Author
|
@ferrandp Y a moyen de merger ça ? |
7a34864 to
b180069
Compare
b180069 to
6b7ae2e
Compare
ferrandp
approved these changes
Oct 16, 2025
6b7ae2e to
3aa22d4
Compare
|
Now, that means we can used custom python script directly for this image? |
Contributor
Author
Python is included on the ubuntu-latest Docker image which is the base of ours. We use it as a dependency of the google cloud CLI which is added to support firebase (see README). When upgrading to latest version of ubuntu it introduced a crash because of PEP 668. I fixed this issue in this PR to be compliant. This PR isn't supposed to add python support. Though I guess we already supported it somehow, it isn't a first class feature of the image. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ubuntu latest introduced a crash on the release pipeline.
It's an error that appears when using pip install because it might interferes with other python directories for the user.
Since this is in the context of a short lived docker container I decided to just ignore this error adding the corresponding flag.