Skip to content

File error reporting - #3103

Open
Prospect138 wants to merge 23 commits into
f3d-app:masterfrom
Prospect138:feature/file_error_reporting
Open

File error reporting#3103
Prospect138 wants to merge 23 commits into
f3d-app:masterfrom
Prospect138:feature/file_error_reporting

Conversation

@Prospect138

@Prospect138 Prospect138 commented May 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Describe your changes

Add distinguish between a file of unsupported extension and a file of unsupported content on f3d load.
WIP

Issue ticket number and link if any

#3000

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

AI Disclosure

  • I did not use AI to generate any of the content of that pull request
  • I used AI to generate code in that pull request, if yes please disclose which part of the code was generated and with which model.
  • ...

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

@mwestphal
mwestphal self-requested a review May 3, 2026 12:44
mwestphal
mwestphal reviewed May 3, 2026
View reviewed changes

@mwestphal mwestphal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to request a review whenever needed, top right :)

mwestphal
mwestphal reviewed May 3, 2026
View reviewed changes
Comment thread application/F3DOptionsTools.h Outdated
@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: c, python, java, webassembly.

@mwestphal

mwestphal commented May 28, 2026

Copy link
Copy Markdown
Member

@Prospect138 need help moving forward ?

@mwestphal mwestphal linked an issue May 28, 2026 that may be closed by this pull request
Add distinction between unsupported extension / unsupported content #3000
Open
@Prospect138
Prospect138 force-pushed the feature/file_error_reporting branch from b4e350c to acc5d29 Compare May 28, 2026 19:59
@Prospect138
Prospect138 marked this pull request as ready for review May 28, 2026 20:31
@Prospect138
Prospect138 requested a review from a team as a code owner May 28, 2026 20:31
mwestphal
mwestphal reviewed May 29, 2026
View reviewed changes
Comment thread library/public/reader_types.h Outdated
mwestphal
mwestphal reviewed May 29, 2026
View reviewed changes
Comment thread library/public/reader_types.h Outdated
mwestphal
mwestphal reviewed May 29, 2026
View reviewed changes
Comment thread library/public/reader_types.h Outdated
mwestphal
mwestphal reviewed May 29, 2026
View reviewed changes
Comment thread library/public/scene.h Outdated
mwestphal
mwestphal reviewed May 29, 2026
View reviewed changes
Comment thread doc/libf3d/03-OPTIONS.md Outdated
mwestphal
mwestphal reviewed May 29, 2026
View reviewed changes

@mwestphal mwestphal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at first glance lookss good, lets settle on the API first. @Meakk @snoyer please take a look at the public changes

@mwestphal
mwestphal requested review from Meakk and snoyer May 29, 2026 06:03
@Meakk

Meakk commented May 29, 2026

Copy link
Copy Markdown
Member

Looks ok to me. I agree with your suggestion of moving the enum to the scene scope.

mwestphal
mwestphal reviewed May 29, 2026
View reviewed changes
Comment thread library/plugin/reader.h Outdated
mwestphal
mwestphal requested changes May 29, 2026
View reviewed changes

@mwestphal mwestphal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on quick look, one change needed

mwestphal
mwestphal reviewed Jun 3, 2026
View reviewed changes

@mwestphal mwestphal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

starting to look good, let me know when you need a proper review by requesting a review top right.

@Prospect138
Prospect138 requested a review from mwestphal June 5, 2026 09:51
mwestphal
mwestphal requested changes Jun 8, 2026
View reviewed changes

@mwestphal mwestphal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes needed

Comment thread library/public/scene.h Outdated
Comment thread library/plugin/reader.h Outdated
Comment thread library/src/reader.cxx Outdated
Comment thread library/plugin/reader.h Outdated
Comment thread library/src/scene_impl.cxx Outdated
Comment thread library/src/scene_impl.cxx Outdated
Comment thread webassembly/F3DEmscriptenBindings.cxx Outdated
Comment thread doc/libf3d/03-OPTIONS.md Outdated
Comment thread doc/user/03-OPTIONS.md Outdated
Comment thread library/src/reader.cxx Outdated
@mwestphal

mwestphal commented Jun 8, 2026

Copy link
Copy Markdown
Member

@snoyer fyi

@mwestphal

mwestphal commented Jul 5, 2026

Copy link
Copy Markdown
Member

Need any help moving forward @Prospect138 ?

@Prospect138

Prospect138 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

@mwestphal yes, sorry, im facing really big load in job/life, Ill return after ~1 week and yes, it seems like i need some help :). Or I could give that pr to someone else if needed, but again, im willing to finish this one.

@mwestphal

mwestphal commented Jul 9, 2026

Copy link
Copy Markdown
Member

im willing to finish this one.

Great :)

it seems like i need some help

Ping me whenever

@Prospect138
Prospect138 force-pushed the feature/file_error_reporting branch from 05bbbe7 to 31b208b Compare July 21, 2026 22:01
@Prospect138
Prospect138 requested a review from mwestphal July 22, 2026 14:07
@mwestphal

mwestphal commented Jul 22, 2026

Copy link
Copy Markdown
Member

please resolve adressed discussions @Prospect138

@Prospect138
Prospect138 requested a review from Meakk August 4, 2026 18:43
@Meakk

Meakk commented Aug 4, 2026

Copy link
Copy Markdown
Member

Rebase on master in needed

@Prospect138
Prospect138 force-pushed the feature/file_error_reporting branch from 97d21f2 to 3af2fc7 Compare August 4, 2026 20:10
@mwestphal

mwestphal commented Aug 5, 2026

Copy link
Copy Markdown
Member

\ci fast

mwestphal
mwestphal requested changes Aug 6, 2026
View reviewed changes

@mwestphal mwestphal left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some remarks not properly adressed, you can find them in the file diff easily if needed.

@Prospect138
Prospect138 requested a review from mwestphal August 7, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snoyer snoyer Awaiting requested review from snoyer
@Meakk Meakk Awaiting requested review from Meakk
@mwestphal mwestphal Awaiting requested review from mwestphal

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

ci:fast

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add distinction between unsupported extension / unsupported content

3 participants

@Prospect138 @mwestphal @Meakk