Skip to content

fix: do not set Vary: Origin for static string origin option #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vansh1811 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: do not set Vary: Origin for static string origin option #405

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
(function () {

'use strict';

var assign = require('object-assign');
Expand Down Expand Up @@ -45,15 +44,12 @@
value: '*'
}]);
} else if (isString(options.origin)) {
// fixed origin
// fixed origin: response is always the same regardless of request Origin,
// so Vary: Origin must NOT be set (per fetch spec, see issue #332)
headers.push([{
key: 'Access-Control-Allow-Origin',
value: options.origin
}]);
headers.push([{
key: 'Vary',
value: 'Origin'
}]);
} else {
isAllowed = isOriginAllowed(requestOrigin, options.origin);
// reflect origin
Expand All @@ -66,7 +62,6 @@
value: 'Origin'
}]);
}

return headers;
}

Expand Down Expand Up @@ -94,7 +89,6 @@
function configureAllowedHeaders(options, req) {
var allowedHeaders = options.allowedHeaders || options.headers;
var headers = [];

if (!allowedHeaders) {
allowedHeaders = req.headers['access-control-request-headers']; // .headers wasn't specified, so reflect the request headers
headers.push([{
Expand All @@ -110,7 +104,6 @@
value: allowedHeaders
}]);
}

return headers;
}

Expand Down