test: add coverage for origin callback edge cases#401
Open
mahmoodhamdi wants to merge 1 commit intoexpressjs:masterfrom
Open
test: add coverage for origin callback edge cases#401mahmoodhamdi wants to merge 1 commit intoexpressjs:masterfrom
mahmoodhamdi wants to merge 1 commit intoexpressjs:masterfrom
Conversation
Add tests for behaviors that were previously untested: - Origin callback receives the correct request origin parameter - Errors from origin callback are forwarded to next() - Origin callback returning a specific string (not just boolean) - Preflight requests with regexp origin - Preflight requests with array of origin checks - Preflight requests with origin set to true - Methods option specified as a string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Added 7 tests covering origin callback behaviors that were previously untested, despite 100% line coverage.
Why
While working with
corsin my Express APIs, I was reading through the test suite and noticed several origin callback edge cases that lacked explicit test coverage. Even though line coverage was already at 100%, these behavioral scenarios weren't being validated:req.headers.originvaluenext(err)true/false) from the origin callback sets the correctAccess-Control-Allow-OriginandVaryheadersOPTIONSrequests work correctly whenoriginis aRegExpOPTIONSrequests work correctly whenoriginis an array of checksorigin: true— verifiesOPTIONSrequests reflect the request origin and include default methodsmethodsas a comma-separated string (not just an array) works on preflightTesting