Repository navigation
Conversation
tsapeta
marked this pull request as ready for review
October 11, 2026 16:04
An `Enumerable` enum, `@Record`, `@Union`, or `@SharedObject` declared in another type's body or in a file-scope `extension` is now reported under its qualified Swift name (`Options.Encoding`). Refs resolve from the type they are written in, outward to file scope, and a resolved ref takes the qualified name of its declaration. `schemaVersion` is now 7.
Give a module class the qualified name of its shared object, resolve `Self.`-qualified refs, skip a nested `@ExpoModule` outright, and stop walking function bodies, accessors, and closures. `RefIndex` keeps one table.
tsapeta
force-pushed
the
tsapeta1/eng-27128-scanner-report-nested-enumerable-enums-records-unions-and
branch
from
October 11, 2026 17:30
b284170 to
9074c70
Compare
tsapeta
deleted the
tsapeta1/eng-27128-scanner-report-nested-enumerable-enums-records-unions-and
branch
October 11, 2026 17:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ENG-27128.
scan-exportsonly reported file-scope declarations. AnEnumerableenum,@Record,@Union, or@SharedObjectdeclared inside another type was missing, so every ref to it stayed unresolved (Encodinginexpo-crypto'sDigestOptions,NotificationTypeandImpactStyleinexpo-haptics' module).extensions. A nested type is reported under its qualified Swift name, for exampleOptions.Encoding. A defaultjsNamestays the declared name, as the macros spell it. Types local to a function body or a closure are still skipped.@ExpoModuleis reported, because autolinking registers no other.Self.Xstarts at the type itself).EncodinginOptionsfindsOptions.Encodingbefore a file-scopeEncoding. A qualifier the scan does not declare is still dropped (Media.StatusfindsStatus).nameis now the qualified name of its declaration, so a consumer finds the declaration by an exact match. A module'sclassesentry takes the qualified name of its shared object the same way.schemaVersionis now 7, andsrc/types.tsfollows.Test Plan
swift testinapple/passes, with new tests for nested types, types in extensions, local types, scoped lookup and shadowing, and a module class nested in its module, andSelf.-qualified refs.npm run typecheckpasses.