Skip to content

[build-tools] Re-enable 3rd party precompiled modules#3681

Open
sjchmiela wants to merge 1 commit intomainfrom
stanley/add-expoprecompiledmodulesbaseurl-2
Open

[build-tools] Re-enable 3rd party precompiled modules#3681
sjchmiela wants to merge 1 commit intomainfrom
stanley/add-expoprecompiledmodulesbaseurl-2

Conversation

@sjchmiela
Copy link
Copy Markdown
Contributor

Summary

  • Re-enable EXPO_PRECOMPILED_MODULES_BASE_URL for iOS pod installs so third-party precompiled modules are used alongside Expo modules.
  • Keep the env scoped to pod install only, and proxy the base URL through EAS_BUILD_COCOAPODS_CACHE_URL when CocoaPods cache is enabled.
  • Update pod install unit coverage for the default storage URL and proxied URL behavior.

Testing

  • Added focused unit tests for direct and proxied precompiled modules base URL resolution.
  • Ran yarn exec oxfmt on the touched files.
  • Ran focused @expo/build-tools pod tests and package typecheck; both passed.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.52%. Comparing base (64874f7) to head (8ae185a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3681      +/-   ##
==========================================
+ Coverage   56.51%   56.52%   +0.01%     
==========================================
  Files         887      887              
  Lines       38416    38422       +6     
  Branches     8007     8008       +1     
==========================================
+ Hits        21707    21713       +6     
  Misses      16611    16611              
  Partials       98       98              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjchmiela sjchmiela added the no changelog PR that doesn't require a changelog entry label May 6, 2026
@sjchmiela sjchmiela marked this pull request as ready for review May 6, 2026 21:46
@sjchmiela sjchmiela requested a review from chrfalch May 6, 2026 21:46
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

Copy link
Copy Markdown

@chrfalch chrfalch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog PR that doesn't require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants