Skip to content

[eas-cli] eas go server-side project setup and SDK version selection#3657

Open
gwdp wants to merge 1 commit intomainfrom
gwdp/eas-go-v2-mutation
Open

[eas-cli] eas go server-side project setup and SDK version selection#3657
gwdp wants to merge 1 commit intomainfrom
gwdp/eas-go-v2-mutation

Conversation

@gwdp
Copy link
Copy Markdown
Contributor

@gwdp gwdp commented Apr 30, 2026

Why:

Remove local project setup and npm install from eas go, enable multiple Expo Go SDK versions server-side, and reduce surface area in the CLI.

How:

  • Calls expoGoRepackConfiguration to get server-synthesized project files per SDK version
  • Packs them in-memory into a tar.gz and uploads tarball + eas.json + package.json to GCS
  • Calls createExpoGoRepackWorkflowRun with bucket keys + optional sdkVersion
  • Adds optional --sdk-version flag to select the Expo Go SDK version

Test Plan:

Base: #3514
x-ref: https://github.com/expo/universe/pull/27053 (merged)

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

❌ Patch coverage is 33.00000% with 67 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.57%. Comparing base (64874f7) to head (cb2c55a).

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/go.ts 6.56% 57 Missing ⚠️
...es/eas-cli/src/utils/workflowProjectSourceUtils.ts 75.87% 7 Missing ⚠️
...es/eas-cli/src/graphql/queries/WorkflowRunQuery.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3657      +/-   ##
==========================================
+ Coverage   56.51%   56.57%   +0.07%     
==========================================
  Files         887      888       +1     
  Lines       38416    38410       -6     
  Branches     8007     8004       -3     
==========================================
+ Hits        21707    21727      +20     
+ Misses      16611    16585      -26     
  Partials       98       98              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gwdp added a commit that referenced this pull request Apr 30, 2026
Remove buildExpoConfig in favor of a short stub inside setupCredentialsAsync
(slug, bundle id, project id) so we do not duplicate server app.json shape.
Document V2 workflow dispatch and sdkVersion behavior under PR #3657.
@gwdp gwdp force-pushed the gwdp/eas-go-v2-mutation branch from 35bd5dc to 0239880 Compare May 5, 2026 22:24
gwdp added a commit that referenced this pull request May 6, 2026
Remove buildExpoConfig in favor of a short stub inside setupCredentialsAsync
(slug, bundle id, project id) so we do not duplicate server app.json shape.
Document V2 workflow dispatch and sdkVersion behavior under PR #3657.
@gwdp gwdp force-pushed the gwdp/eas-go-v2-mutation branch 6 times, most recently from 65f9e13 to 3404868 Compare May 7, 2026 02:30
@gwdp gwdp force-pushed the gwdp/eas-go-v2-mutation branch from 3404868 to cb2c55a Compare May 7, 2026 03:52
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

✅ Thank you for adding the changelog entry!

@gwdp gwdp marked this pull request as ready for review May 7, 2026 03:58
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

@gwdp gwdp changed the title [eas-cli] Remove client side project setup on expo go command [eas-cli] eas go server-side project setup and SDK version selection May 7, 2026
@gwdp gwdp requested a review from sjchmiela May 7, 2026 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant