[codex] Add simulator-id support to build run and dev#3632
Draft
mmichels-brex wants to merge 1 commit intoexpo:mainfrom
Draft
[codex] Add simulator-id support to build run and dev#3632mmichels-brex wants to merge 1 commit intoexpo:mainfrom
mmichels-brex wants to merge 1 commit intoexpo:mainfrom
Conversation
mmichels-brex
changed the title
mmichels-brex
force-pushed
the
codex/build-dev-simulator-id
branch
from
fe7c18e to
a4ac3ec
Compare
mmichels-brex
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
--simulator-idflag for iOS simulator runs without overloading the existing--idbuild selector.The new option is shared by:
eas build:run, where--idcontinues to mean build ID and--simulator-idselects the target iOS simulator UDIDeas build:dev, where--simulator-idselects the target iOS simulator UDID for both fingerprint-cache hits and newly-created buildsThe shared run helpers now accept optional run options, and the iOS simulator selector resolves the provided simulator id before booting/installing. Android rejects
--simulator-idbecause the target-id behavior is iOS-simulator specific.Validation
yarn exec oxfmt packages/eas-cli/src/commands/build/run.ts packages/eas-cli/src/commands/build/dev.ts packages/eas-cli/src/build/runBuildAndSubmit.ts packages/eas-cli/src/run/ios/run.ts packages/eas-cli/src/run/ios/simulator.ts packages/eas-cli/src/run/run.tsgit diff --check@expo/logger,@expo/eas-build-job,@expo/steps,@expo/eas-jsonyarn workspace eas-cli typecheckandyarn workspace eas-cli typecheck-for-buildwere attempted, but both are blocked by existing@expo/apple-utilsmetadata/App Clip type mismatches unrelated to this change.