Http DELETE support, lightweight callbacks.#1
Open
akolechkin wants to merge 2 commits intoexfm:masterfrom
Open
Http DELETE support, lightweight callbacks.#1akolechkin wants to merge 2 commits intoexfm:masterfrom
akolechkin wants to merge 2 commits intoexfm:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
I would like to suggest some changes in rocket.
rocket/http_handling.py
When i worked with sailthru.com i found that rocket not working with send.delete.
I've investigated that problem, and drop on a problem with urllib2. It doesn't support http DELETE method out of box. I created a successor of urllib2.Request class, with various http-methods support.
Another issue, i found, you can see here https://github.com/exfm/rocket/blob/master/rocket/http_handling.py#L81
RocketAPIError is not in namespace, and i couldn't find implementation of this class, as well i don't know behavior of this class.
rocket/rocket.py
It looks like an improvement, for easy support of lightweight callbacks to a method.
f.e I would like to handle any error that could happen at remote api call.
I can write a handler like that: