Issue #27 Fix: Test runner : duplicate lines in error output

[GANES1998]

Fix for issue #27 that outputs duplicate lines in error output
line #56 command the prints the statement (;p) is removed

[GANES1998]

Hey @ErikSchierboom, I have made the changes for fix. Kindly review and let me know if it is fine.

[ErikSchierboom]

@GANES1998 The tests are now broken. Could you update the outdated expected_results.json files in the tests/* folders? See https://github.com/exercism/clojurescript-test-runner/pull/28/checks?check_run_id=3826265986 for which ones are now failing.

[GANES1998]

Sure I'll update those

[ErikSchierboom]

@GANES1998 An easy way to do that is to run ./bin/run-tests-in-docker.sh and then copying the results.json to the expected_results.json.

[ErikSchierboom]

@GANES1998 There are three more failing tests I believe.

[ErikSchierboom]

@GANES1998 It looks like there are some newlines missing. You should see the errors too when running ./bin/run-tests-in-docker.sh, so that way you'll know if CI would be passing or not.

[GANES1998]

Sure sorry @ErikSchierboom, Got it will make changes and test.

[ErikSchierboom]

@GANES1998 The CI is red. Are you still working on this?

[GANES1998]

Yes, Can you please guide me, what tests are failing and why.

…

On Thu, Oct 14, 2021 at 10:51 AM Erik Schierboom ***@***.***> wrote: @GANES1998 <https://github.com/GANES1998> The CI is red. Are you still working on this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#28 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFHWQWCNX42U3RTDZ24NFJTUGZSGBANCNFSM5FQ66AZA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[ErikSchierboom]

@GANES1998 You can find the CI output here: https://github.com/exercism/clojurescript-test-runner/pull/28/checks?check_run_id=3838757994 Looking at that output, it appears that there are some missing new lines at the end of files and one message that invalid.

You should be able to check this via ./bin/run-tests-in-docker.sh.

[GANES1998]

Sorry, Thanks for bearing with me @ErikSchierboom, I get the following while trying to run run-test-in-docker .sh

Can you please help me with this,

[GANES1998]

Sorry, Thanks for bearing with me @ErikSchierboom, I get the following while trying to run run-test-in-docker .sh

Can you please help me with this,

[ErikSchierboom]

@GANES1998 I think you have to do docker login (you need to have a dockerhub account) first.