fix: horario bug - stateState duplicated during build#56
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Este PR aborda un bug en la pantalla de Horario causado por ejecutar inicialización/lógica durante build, evitando efectos secundarios repetidos y separando la carga de datos del renderizado del contenido.
Changes:
- Mueve
horarioController.init(context)fuera debuildhaciainitStatey reemplaza elFutureBuildercon unFuturealmacenado en estado. - Extrae el
Scaffoldprincipal a un widgetStateless(HorarioScreenContent) que recibe el horario ya cargado. - Ajusta
HorarioController.initpara aplicarsetZoomy centrar el viewport en unpostFrameCallback.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lib/screens/horario/horario_screen.dart | Refactor de carga/render para evitar efectos secundarios en build y separar contenido en widget stateless. |
| lib/core/services/controllers/horario_controller.dart | Diferir setZoom/centrado del viewport al primer frame para evitar problemas durante construcción. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.