Conversation
|
Caller needs to pass: Defaults are: |
rach-id
left a comment
rach-id
left a comment
There was a problem hiding this comment.
This stuff is so cool 🚀 🚀
No blocking feedback, just a passing by review to understand more :D
|
|
||
| const ( | ||
| DEFAULT_SAT_AMOUNT = 1000 | ||
| DEFAULT_SAT_FEE = 200 |
There was a problem hiding this comment.
[Question]
Shouldn't this be configurable? Because, if I understand right, the whole block data will be posted, not just a commitment to it. Thus, its size can change. Wouldn't it be better to have the fee specified as vBytes so that it changes according to the amount of data being posted?
| revealSatAmount btcutil.Amount | ||
| revealSatFee btcutil.Amount |
There was a problem hiding this comment.
[Proposal]
If these are used also for the commit transaction, proposal to rename to txAmount and txFee as they would be used for the commit and also the reveal
| network *chaincfg.Params | ||
| revealSatAmount btcutil.Amount | ||
| revealSatFee btcutil.Amount | ||
| revealPrivateKeyWIF *btcutil.WIF |
There was a problem hiding this comment.
[Proposal]
Similar, if the same key will be used for the commit tx, proposal to rename to privateKeyWIF
| const ( | ||
| DEFAULT_SAT_AMOUNT = 1000 | ||
| DEFAULT_SAT_FEE = 200 | ||
| DEFAULT_PRIVATE_KEY = "5JoQtsKQuH8hC9MyvfJAqo6qmKLm8ePYNucs7tPu2YxG12trzBt" |
There was a problem hiding this comment.
I don't like this. Private keys should be provided and not hardcoded.
4 participants
Fixes #7