-
Notifications
You must be signed in to change notification settings - Fork 3
[7.x.x] Improvements to fn:format-number
#152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adamretter
wants to merge
12
commits into
develop-7.x.x
Choose a base branch
from
7.x.x/hotfix/fn-format-number
base: develop-7.x.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en using fn:format-number Closes eXist-db/exist#5943
…imal-format' prolog options in XQuery
…n exponent and also a percent or per-mille character
… Format must be distinct
…with the same name
34fd147 to
f68d83c
Compare
f68d83c to
d833ec0
Compare
…r in the exponent part of the picture string given to fn:format-number
…re is no decimal separator in the picture, or there are no fractional digits, and the decimal separator is the right-most character
…part-grouping-positions. All W3C QT3 format-number tests are now passing except: 1. `numberformat121` and `numberformat122` which raise a java.lang.StackOverflowError due to a lack of tail-call-optimisation 2. `numberformat127` and `numberformat128` which appear to be incorrect, see: w3c/qt3tests#73
92898c6 to
0daf9df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
declare default decimal-formatanddeclare decimal-format; these can now be used byfn:format-numberfn:format-numberCloses fn:format-number - small number formatted with exponent fails eXist-db/exist#5943
All W3C QT3 format-number tests are now passing except:
1.
numberformat121andnumberformat122which raise ajava.lang.StackOverflowErrordue to a lack of tail-call-optimisation2.
numberformat127andnumberformat128which should fail on XQuery 1.0 and 3.0, and pass on XQuery 3.1. In Elemental these will pass on XQuery 1.0, 3.0, and 3.1.