Skip to content

Use the HairlineWidth property (from StyleSheet API) to render borders. #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DupK wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use the HairlineWidth property (from StyleSheet API) to render borders. #51

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ef334b
Use the HairlineWidth property (from StyleSheet API) to render borders.
DupK May 31, 2018
d217a44
Use the HairlineWidth property (from StyleSheet API) to render border…
DupK Jun 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ class SettingsList extends React.Component {
return (
<View key={'group_' + index}>
<Text style={[{margin:5},group.header.headerStyle]} numberOfLines={group.header.headerNumberOfLines} ellipsizeMode="tail" ref={group.header.headerRef}>{group.header.headerText}</Text>
<View style={{borderTopWidth:1, borderBottomWidth:1, borderColor: this.props.borderColor}}>
<View style={{borderTopWidth:StyleSheet.hairlineWidth, borderBottomWidth:StyleSheet.hairlineWidth, borderColor: this.props.borderColor}}>
{group.items.map((item, index) => {
return this._itemView(item,index, group.items.length);
})}
Expand All @@ -95,7 +95,7 @@ class SettingsList extends React.Component {
let items;
if (group.items.length > 0) {
items = (
<View style={{borderTopWidth:1, borderBottomWidth:1, borderColor: this.props.borderColor}}>
<View style={{borderTopWidth:StyleSheet.hairlineWidth, borderBottomWidth:StyleSheet.hairlineWidth, borderColor: this.props.borderColor}}>
{group.items.map((item, index) => {
return this._itemView(item,index, group.items.length);
})}
Expand Down Expand Up @@ -168,11 +168,11 @@ class SettingsList extends React.Component {

if(item.borderHide) {
switch(item.borderHide) {
case 'Top' : border = {borderBottomWidth:1, borderColor: this.props.borderColor}; break;
case 'Bottom' : border = {borderTopWidth:1, borderColor: this.props.borderColor}; break;
case 'Top' : border = {borderBottomWidth:StyleSheet.hairlineWidth, borderColor: this.props.borderColor}; break;
case 'Bottom' : border = {borderTopWidth:StyleSheet.hairlineWidth, borderColor: this.props.borderColor}; break;
}
} else {
border = index === max-1 ? {borderWidth:0} : {borderBottomWidth:1, borderColor: this.props.borderColor};
border = index === max-1 ? {borderWidth:0} : {borderBottomWidth: StyleSheet.hairlineWidth, borderColor: this.props.borderColor};
}

let titleInfoPosition = item.titleInfoPosition ? item.titleInfoPosition : this.props.defaultTitleInfoPosition;
Expand All @@ -184,11 +184,11 @@ class SettingsList extends React.Component {
{item.isAuth ?
<View style={item.titleBoxStyle ? item.titleBoxStyle : [styles.titleBox, border]}>
<View style={{paddingLeft:5,flexDirection:'column',flex:1}}>
<View style={{borderBottomWidth:1,borderColor:this.props.borderColor}}>
<View style={{borderBottomWidth:StyleSheet.hairlineWidth,borderColor:this.props.borderColor}}>
<TextInput
ref="UserNameInputBlock"
onSubmitEditing={() => this.refs.PasswordInputBlock.focus()}
style={{flex:1,height:30, borderBottomWidth:1}}
style={{flex:1,height:30, borderBottomWidth:StyleSheet.hairlineWidth}}
placeholder = "username"
{...item.authPropsUser}
/>
Expand Down