fix(examples): enforce timeout parameter in bashkit-pi bash tool#1872
Merged
Conversation
Pass params.timeout (converted from seconds to ms) as an AbortSignal to executeSync, so per-call timeout bounds are actually enforced instead of silently ignored.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 26daa03 | Commit Preview URL Branch Preview URL |
Jun 05 2026, 12:39 AM |
There was a problem hiding this comment.
Pull request overview
This PR fixes the bash tool implementation in the bashkit-pi example so that the timeout parameter exposed in the tool schema is actually enforced during command execution by passing an AbortSignal into bash.executeSync.
Changes:
- Convert
params.timeout(seconds) to milliseconds. - Pass
AbortSignal.timeout(ms)as{ signal }tobash.executeSyncto cancel long-running commands when requested.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+96
to
+102
| // Convert caller-supplied seconds to milliseconds for AbortSignal. | ||
| // If no timeout is given, execute unbounded (subject to Bash instance limits). | ||
| const signal = | ||
| params.timeout != null | ||
| ? AbortSignal.timeout(params.timeout * 1000) | ||
| : undefined; | ||
| const result = bash.executeSync(params.command, { signal }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/bashkit-pi/bashkit-extension.tsexposed atimeoutparameter in its schema but never used it —executeSyncwas always called without any timeout bound.params.timeout(seconds) to milliseconds and pass it as anAbortSignalviaAbortSignal.timeout(ms)toexecuteSync, which accepts{ signal }in itsExecuteOptions.Bashinstance limits).Test plan
cd examples/bashkit-pi && pnpm installtimeout: 1withsleep 5) is cancelled after ~1 sCloses #1870