fix(interpreter): preserve legacy nameref targets#1810
Merged
chaliy merged 2 commits intoMay 30, 2026
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 6b023af | Commit Preview URL | May 30 2026, 09:07 AM |
chaliy
added a commit
that referenced
this pull request
May 30, 2026
Legacy snapshots stored namerefs as `_NAMEREF_<name>=<target>` but the migration discarded marker values, creating self-referential namerefs that break readonly/nameref semantics. Fix `take_prefixed` to return `(stripped_name, marker_value)` pairs and use `namerefs.entry(key).or_insert(target)` so `_NAMEREF_alias=POLICY` correctly becomes `alias -> POLICY`. Adds regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
_NAMEREF_<name>=<target>and the migration discarded marker values, creating self-referential namerefs that break readonly/nameref semantics and allow integrity bypass.Description
take_prefixedincrates/bashkit/src/interpreter/mod.rsto return(stripped_name, marker_value)pairs so marker values are preserved during removal.for (key, _) in take_prefixed(...)and restore legacy namerefs usingfor (key, target) in take_prefixed(...){ namerefs.entry(key).or_insert(target); }so_NAMEREF_alias=POLICYbecomesalias -> POLICY.test_restore_shell_state_migrates_legacy_nameref_targetsthat verifies the marker variable is removed, the nameref resolves to the original target, and readonly protection remains effective when assigning through the alias.Testing
cargo fmt --checkand formatting checks passed.test_restore_shell_state_migrates_legacy_nameref_targetsand the existingtest_restore_shell_stateunder-p bashkit; both tests passed.cargo clippy -p bashkit --all-targets -- -D warningsand the linter completed without warnings.Codex Task