Docker file and other updates along with merged eros-framer updates#123
Docker file and other updates along with merged eros-framer updates#123Melica101 wants to merge 12 commits into
Conversation
| ln -s python$PYTHON_VERSION /usr/bin/python3 | ||
|
|
||
| # upgrade pip | ||
| RUN sudo apt install -y python3.8-distutils |
There was a problem hiding this comment.
consolidate a single version of python (we have 3 at the moment)
There was a problem hiding this comment.
also on line 28
also on line 197
let's keep all installs up the top so there are no surprise version mismatches later
There was a problem hiding this comment.
@arrenglover The 3.8 version seems to work fine for the installs that I added so we can go with that. I have put the installs I added at the top. I haven't made any changes to the previous installs (there is a python 3.7 install on line 75 which can possibly be removed)
| apt update; \ | ||
| apt install -y metavision-*; \ | ||
| fi | ||
| # RUN if [ $hvga -eq 1 ]; then \ |
There was a problem hiding this comment.
do we not want to run the camera for the example anymore? @gaurvigoyal
| ARG YARP_VERSION=3.6.0 | ||
| ARG YCM_VERSION=0.14.0 | ||
| ARG EVENT_DRIVEN_VERSION=main | ||
| ARG YARP_VERSION=master |
There was a problem hiding this comment.
let's keep specific versions for YARP, and YCM
There was a problem hiding this comment.
@arrenglover I tried again and specific versions bring up errors so I went with the main and master again
There was a problem hiding this comment.
latest version of yarp is v3.11.2 latest version of YCM is v0.18.3 - you can have event-driven on main
|
|
||
|
|
||
| # install BIMVEE | ||
| RUN apt install -y libpython3.8-dev python3-h5py |
There was a problem hiding this comment.
same as above - consolidate python versions and keep installs at the top
|
|
||
| # install movenet dependencies | ||
|
|
||
| # use this once the eros-framer.cpp is updated in the movenet repo |
There was a problem hiding this comment.
okay let's switch this back as we fixed the eros-framer
| python3 -m pip install -r requirements.txt && \ | ||
| python3 -m pip install -r requirements.txt | ||
|
|
||
| COPY eros-framer.cpp $SOURCE_FOLDER/hpe-core/example/movenet/eros-framer.cpp |
There was a problem hiding this comment.
we shouldn't need to do this - let's remove
| 2. Create a python environment on you local machine. | ||
| If you want to run this offline only, this option can be used. | ||
| - Create a virtual environment and enter it. | ||
| 2. Create a python environment on your local machine. |
There was a problem hiding this comment.
do we have a good reason to use docker and a local python environment? @gaurvigoyal ?
There was a problem hiding this comment.
There are two different types of users (ones who would run the full pipeline with the data.log we provide and another who just want to try moveEnet's python part and install it natively in their own python environments) and thus having the instructions for the two different cases makes sense.
| @@ -1,33 +1,30 @@ | |||
| #include <yarp/os/all.h> | |||
There was a problem hiding this comment.
do a git pull on main and then a git merge main on this branch to update to the changes already pushed to main about eros-framer
There was a problem hiding this comment.
I don'y think eros-framer is updated in this pull request because it was already done in the last update. therefore you haven't correctly merged main into your branch @gaurvigoyal
…e-core into movenet-updates
4 participants
No description provided.