add irteusg target, add linux-nox test on config.yml#617
Open
add irteusg target, add linux-nox test on config.yml#617
Conversation
5a0244b to
9e43fd7
Compare
Member
Author
|
if you had following error, please run |
5909218 to
1fb6605
Compare
move (defmethod polygon :draw-on, (defmethod line :draw-on (defmethod faceset :draw-on :set-color from irtgl.l define dummy (defmethod faceset :set-color, :paste-texture-from-file it will be defined in irtgl.l with opengl code move (defmethod faceset :draw-on, from irtgl.l move (defmethod coordinates :vertices :draw-on, (defmethod geo::float-vector :vertices :draw-on from irtgl.l
…undp 'x::*display* or add #+:gl for gl::transparent functions
…viewer-dummy, mkae-irtviewer-dummp from irtviewer.l to irtget.l for irteusg
…compile IRTEUSIMGOBJS with eusg, and link LIBIRTEUSIMG with irteusg
…oss compile environment
…so exists, to compile pgsql.l
Affonso-Gui
reviewed
May 12, 2022
| disks)) | ||
| (send (car disks) :set-color (send (elt gl::*face-colors* (* (+ i 4) 32)) :name)) | ||
| (when (memq :gl *features*) | ||
| (send (car disks) :set-color (send (elt gl::*face-colors* (* (+ i 4) 32)) :name))) |
Member
There was a problem hiding this comment.
This will cause read errors on gl::*face-colors* if the gl package is not defined. Using #+:gl might be a better choice.
Member
Author
There was a problem hiding this comment.
@Affonso-Gui Thanks for feedback.
- Set
glas default package : In euslisp/EusLisp@9c5a617, I am definedglas default package, because "X" is already there. Of course, this breaks backward compatibility and will trouble if you do not update both euslisp and jskeus at same time.. - Consider when compile source code with
eusg: If we compile source code with#+glwitheus2oreusg, and load that.sofile witheusgl, then the#+glcode is ignored. When we consider euslisp in Non-X environment, we want to compile all code witheusg. - Afcourse, we will not compile
hanoi.lwitheusgand load witheusgl. I am ok with use#+glat this section. But if your intend to use#+gl#+xwindowfor other codes like https://github.com/euslisp/EusLisp/pull/487/files, we need find better solution.
$ bash ./my-test.sh
+ eus2 my-test.l
"done!!!"
+ eusgl my-test.l
"(memq :gl *features*)"
"#+:gl"
"done!!!"
+ eus2 '(progn (compile-file "my-test.l" :o "my-test-2.so") (exit 0))'
+ eusgl '(progn (compile-file "my-test.l" :o "my-test-gl.so") (exit 0))'
+ eus2 '(load "my-test-2.so" :entry "___my_test")'
"done!!!"
+ eus2 '(load "my-test-gl.so" :entry "___my_test")'
"#+:gl"
"done!!!"
+ eusgl '(load "my-test-2.so" :entry "___my_test")'
"(memq :gl *features*)"
"done!!!"
+ eusgl '(load "my-test-gl.so" :entry "___my_test")'
"(memq :gl *features*)"
"#+:gl"
"done!!!"
```
here is the code.
```
$ cat my-test.l
(defun my-test-func nil
(when (memq :gl *features*)
(print "(memq :gl *features*)"))
#+:gl
(print "#+:gl")
(print "done!!!"))
(eval-when
(eval load)
(my-test-func)
(exit 0))
$ cat my-test.sh
set -x
eus2 my-test.l 2> /dev/null
eusgl my-test.l 2> /dev/null
eus2 "(progn (compile-file \"my-test.l\" :o \"my-test-2.so\") (exit 0))" 2> /dev/null
eusgl "(progn (compile-file \"my-test.l\" :o \"my-test-gl.so\") (exit 0))" 2> /dev/null
eus2 "(load \"my-test-2.so\" :entry \"___my_test\")" 2> /dev/null
eus2 "(load \"my-test-gl.so\" :entry \"___my_test\")" 2> /dev/null
eusgl "(load \"my-test-2.so\" :entry \"___my_test\")" 2> /dev/null
```
Member
There was a problem hiding this comment.
Interesting point. I was unnaware of the #+/- effect on compiled code. (Is this the same in common lisp?)
Adding gl to the default eus packages ( euslisp/EusLisp@9c5a617 ) does
seem like a nice solution for now!
If the problem persists as we deal with minor / user-defined packages I guess we could also update the compiler entry on this. (e.g. default to dynamic evaluation, force static with #.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires euslisp/EusLisp#491
Changes:
01d7bc5 (Kei Okada, 11 seconds ago)
comment out existing test for debug
39ec8a2 (Kei Okada, 43 seconds ago)
.github/workflows/config.yml: add linux-nox
2e5d488 (Kei Okada, 9 minutes ago)
move geo code to irtgeo.l for irteusg
3a6bfe1 (Kei Okada, 30 minutes ago)
run compile_irtg.l with eusg
d625240 (Kei Okada, 88 minutes ago)
add irteusg irteusx irteusgl target
aedf0e7 (Kei Okada, 2 hours ago)
clean up Makefile code, fix dependencies
6c55de7 (Kei Okada, 18 hours ago)
Makefile: clean up irtc.c dependency, which is introduced in
b66b6fa