Open
Conversation
Ryanf55
reviewed
Mar 30, 2024
| @@ -85,6 +85,7 @@ bool GridMapGeo::initializeFromGeotiff(const std::string &path) { | |||
|
|
|||
| const OGRSpatialReference *spatial_ref = dataset->GetSpatialRef(); | |||
| std::string name_coordinate = spatial_ref->GetAttrValue("geogcs"); | |||
Collaborator
There was a problem hiding this comment.
Note - GetSpacialRef can return null, so the code would segfault from a nullptr dereference if the user supplied the path to a dataset that didn't have one.
https://gdal.org/doxygen/classGDALDataset.html#a9bd7f8b54ff4c12756976c7a0116d49a
Ryanf55
reviewed
Mar 30, 2024
| double mapcenter_e = originX + pixelSizeX * width * 0.5; | ||
| double mapcenter_n = originY + pixelSizeY * height * 0.5; | ||
| maporigin_.espg = ESPG::CH1903_LV03; | ||
| maporigin_.espg = static_cast<ESPG>(std::stoi(epsg_code)); |
Collaborator
There was a problem hiding this comment.
FYI, std::stoi could throw if the OGRSpatialReference doesn't have the AUTHORITY attribute because it will return null. You might want to wrap it in try-catch, or return early if the epsg_code == nullptr
Ryanf55
approved these changes
Mar 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Description
The ESPG code was hardcoded before. This PR acquires the code from the tif file directly