Skip to content

Fix outer derivative by replacing cwiseproduct with explicit matvec. #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pbrakel wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix outer derivative by replacing cwiseproduct with explicit matvec. #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions towr/src/height_map.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,12 @@ HeightMap::GetDerivativeOfNormalizedBasisWrt (Direction basis, Dim2D dim,

// outer derivative
Vector3d v = GetBasis(basis, x,y, {});
Vector3d dn_norm_wrt_n = GetDerivativeOfNormalizedVectorWrtNonNormalizedIndex(v, dim);
return dn_norm_wrt_n.cwiseProduct(dv_wrt_dim);
Vector3d result = Vector3d::Zero();
for (auto inner_dim : {X,Y,Z}) {
auto dn_norm_wrt_n = GetDerivativeOfNormalizedVectorWrtNonNormalizedIndex(v, inner_dim);
result = result + dv_wrt_dim(inner_dim) * dn_norm_wrt_n;
}
return result;
}

HeightMap::Vector3d
Expand Down