Skip to content

Conversation

@cuiweixie
Copy link
Contributor

@cuiweixie cuiweixie commented Oct 20, 2025

goos: darwin
goarch: arm64
pkg: github.com/ethereum/go-ethereum/core/types
cpu: Apple M1 Pro
                       │   old.txt    │               new.txt               │
                       │    sec/op    │   sec/op     vs base                │
_modernSigner_Equal-10   101.65n ± 1%   10.29n ± 0%  -89.88% (p=0.000 n=20)

                       │  old.txt   │            new.txt             │
                       │    B/op    │    B/op     vs base            │
_modernSigner_Equal-10   0.000 ± 0%   0.000 ± 0%  ~ (p=1.000 n=20) ¹
¹ all samples are equal

                       │  old.txt   │            new.txt             │
                       │ allocs/op  │ allocs/op   vs base            │
_modernSigner_Equal-10   0.000 ± 0%   0.000 ± 0%  ~ (p=1.000 n=20) ¹
¹ all samples are equal

@cuiweixie cuiweixie force-pushed the optimize_modernSigner branch from 3023473 to 5087a1c Compare October 24, 2025 16:03
@cuiweixie cuiweixie force-pushed the optimize_modernSigner branch from 5087a1c to 0c67e7c Compare October 25, 2025 12:45
@fjl fjl changed the title core/types: optimize modern signer core/types: optimize modernSigner.Equal Oct 27, 2025
@fjl fjl merged commit 33dbd64 into ethereum:master Oct 27, 2025
6 of 7 checks passed
@fjl fjl added this to the 1.16.6 milestone Oct 27, 2025
@fjl fjl removed the status:triage label Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants