feat: add op-succint contracts

[stevennevins]

Description

The main changes include the addition of a new access control contract, new error and type definitions specific to the new OP_SUCCINCT game type, an interface for an external verifier, and the OPSuccinctFaultDisputeGame.

These changes lay the groundwork to support ZK proofs as an option for the OP Stack. We will begin integrating these contracts and their infrastructure into the monorepo. This is the first PR in a series of PRs to integrate Zk proofs into our onchain and offchain components.

Tests

In a follow-up up PR

Additional context

Design Doc: https://github.com/ethereum-optimism/design-docs/pull/356/files

Metadata

[codecov]

Codecov Report

❌ Patch coverage is 0% with 196 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.76%. Comparing base (05d75fc) to head (5185ef5).
⚠️ Report is 4 commits behind head on develop.

Files with missing lines	Patch %	Lines
...rock/src/dispute/zk/OPSuccinctFaultDisputeGame.sol	0.00%	165 Missing ⚠️
...contracts-bedrock/src/dispute/zk/AccessManager.sol	0.00%	31 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #18277      +/-   ##
===========================================
+ Coverage    76.25%   79.76%   +3.51%     
===========================================
  Files          179      126      -53     
  Lines        10732     6895    -3837     
===========================================
- Hits          8184     5500    -2684     
+ Misses        2404     1395    -1009     
+ Partials       144        0     -144     

Flag	Coverage Δ
cannon-go-tests-64	?
contracts-bedrock-tests	79.76% <0.00%> (-2.34%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...contracts-bedrock/src/dispute/zk/AccessManager.sol	0.00% <0.00%> (ø)
...rock/src/dispute/zk/OPSuccinctFaultDisputeGame.sol	0.00% <0.00%> (ø)

... and 55 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Inphi]

For licensing reasons, the smart contracts should contain attribution to Succinct Labs in a way that's more explicit than the natspec authorship. I suggest something like:

// Derived from https://github.com/succinctlabs/op-succinct (at <commit-hash>)

Or simply copy paste the contents of their MIT LICENSE near the top of these contracts.

[stevennevins]

For licensing reasons, the smart contracts should contain attribution to Succinct Labs in a way that's more explicit than the natspec authorship. I suggest something like:

// Derived from https://github.com/succinctlabs/op-succinct (at <commit-hash>)

Or simply copy paste the contents of their MIT LICENSE near the top of these contracts.

agreed! Will just add to the game contract since we will be removing the access manager in a follow up

[ajsutton]

LGTM.

[ajsutton]

Could we add an issue to fix the contracts and remove this exception again. Totally fine to have it for now since we're importing directly but given these are new contracts we're importing we should try to make them follow best practice if we can and I don't think we identified any initializable work previously.

[stevennevins]

yeah this is a good suggestion and i can take a look into why this was the case. i wonder if it was from using blueprints previously and now we don't need do this anymore