Add DeployFeesDepositor script #18223
Open
+270
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #18223 +/- ##
===========================================
+ Coverage 76.62% 82.08% +5.46%
===========================================
Files 179 124 -55
Lines 10717 6694 -4023
===========================================
- Hits 8212 5495 -2717
+ Misses 2359 1199 -1160
+ Partials 146 0 -146
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
0xDiscotech
reviewed
Nov 10, 2025
packages/contracts-bedrock/scripts/deploy/DeployFeesDepositor.s.sol
Outdated
Show resolved
Hide resolved
Comment on lines
+87
to
+88
| IProxy _feesDepositorProxy, | ||
| IFeesDepositor _feesDepositorImpl, |
Contributor
There was a problem hiding this comment.
Missing natSpec for these two
packages/contracts-bedrock/scripts/deploy/DeployFeesDepositor.s.sol
Outdated
Show resolved
Hide resolved
Co-authored-by: Disco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a script for deploying the
FeesDepositor. This script follows the pattern of other existing 'one off' deployment scripts (ie.DeployMips2.s.sol) as well as the tests of those scripts.