Adds injectable HTTP requester support to client#13
Open
jobezic wants to merge 1 commit intoethanndickson:mainfrom
Open
Adds injectable HTTP requester support to client#13jobezic wants to merge 1 commit intoethanndickson:mainfrom
jobezic wants to merge 1 commit intoethanndickson:mainfrom
Conversation
Owner
ethanndickson
left a comment
There was a problem hiding this comment.
Thanks for the PR! I hope this library can be of some use :)
The Rust ecosystem has changed a lot since this was written, and core parts of the library like our HTTP Client code could do with some modernizing & generally some love. 🥲
sep2_client/src/client.rs
Outdated
| pub struct Client { | ||
| addr: Arc<String>, | ||
| inner: ClientInner, | ||
| inner: Arc<dyn HttpRequester>, |
Owner
There was a problem hiding this comment.
Instead of replacing the enum here, could we perhaps extend it?
IIRC, something like this could work:
pub(crate) enum ClientInner {
Https(HTTPSClient),
Http(HTTPClient),
Custom(Arc<dyn HttpRequester>),
}
Author
There was a problem hiding this comment.
sounds like a good idea, check my last changes please.
1978dc8 to
43e73c1
Compare
43e73c1 to
aca801c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a trait for HTTP requesters, allowing custom implementations to be injected into the client.
Enables greater flexibility and testability by decoupling HTTP logic from the client core.