Skip to content

Port from workload repo - #1

Merged
han0110 merged 26 commits into
mainfrom
han/feature/port-from-workload
Jan 2, 2026
Merged

Port from workload repo#1
han0110 merged 26 commits into
mainfrom
han/feature/port-from-workload

Conversation

@han0110

@han0110 han0110 commented Dec 31, 2025

Copy link
Copy Markdown
Collaborator
  • Port guest lib crates and bin crates from eth-act/zkevm-benchmark-workload, reorganize into:
    • <repo>/crates - Guest lib crates in shared workspace, provides core logic of guest program, and fn for host to generate the input to zkVM
    • <repo>/bin/{guest}/{zkvm} - Bin crate in independent workspace, might not support all zkVM if the {guest} is not ready
      • For stateless-validator-reth, we cleanup many unused crates that's used to open some feature gates (that's already opened somewhere)
  • Also ported the "Compile and Release Compiled Guests" workflow, to upload compiled guest if it's push to main, and to release if it's tagging
  • TODO
    • CI to check dependency consistency between lib and bin crates (e.g. same ere or revm version)
    • Update README.md

@han0110
han0110 marked this pull request as draft December 31, 2025 10:37
@han0110
han0110 force-pushed the han/feature/port-from-workload branch 2 times, most recently from 1c3f325 to 6955cda Compare December 31, 2025 14:26
@han0110
han0110 marked this pull request as ready for review January 1, 2026 05:31
This was referenced Jan 1, 2026

@jsign jsign left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

- name: Get Ere tag
id: get_ere_tag
run: |
ERE_TAG=$(cargo tree -p ere-platform-trait | head -n 1 | sed -E 's/ere-platform-trait v([0-9.]+) \(.*#([a-f0-9]{7}).*/\1-\2/')

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, we should prob do the same in the tag we maintained manually for integration tests. (Maybe part of the other PR but haven't look at it yet since it is based on this one)

run: |
.github/scripts/check-duplicate-pkg.sh \
--include '^(alloy|ethrex|ere|reth|revm)' \
--exclude '^alloy-trie$' # Crate `mpt` depends on an older `alloy-trie` but it's okay.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! I was expecting to see this. I also remember that alloy-rlp was also required to be different version than what reth uses... not sure why it doesn't appear here though.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I think it's because the diff (0.3.12 vs 0.3.8) is not the leading non-zero digit, so cargo resolves to the latest one.

Comment on lines +65 to +66
# ethrex is not no_std compatible
- crate: stateless-validator-ethrex

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a side note, some days ago, chatting with Ethrex team they are thinking of working of making it no_std compatible. If they do, we can change this in the future.

@han0110
han0110 force-pushed the han/feature/port-from-workload branch from cb5a75d to 9c8fedd Compare January 2, 2026 01:52
@han0110
han0110 merged commit f7b0cbf into main Jan 2, 2026
34 checks passed
@han0110
han0110 deleted the han/feature/port-from-workload branch January 2, 2026 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants