Fix ELCIC nonneutral for CPU, disable for GPU - #5409
Open
reinaual wants to merge 2 commits into
Open
Conversation
reinaual
force-pushed
the
fix_elc
branch
2 times, most recently
from
August 4, 2026 14:52
4193e6f to
c67f5ee
Compare
Several corrections used the wrong z-box dimension. This hopefully found all, by checking continuity and explicit derivatives of energies.
…tric ELC with GPU The constant-potential mode models the two dielectric interfaces as electrodes held at a fixed potential difference. Without a dielectric contrast there are no electrodes, and the flag was silently ignored. The P3M-GPU is ignoring charges assigned with charge_assign, as used in ELC. It's using it's own charge-assignment, based on the particle buffer on the GPU. Disabling for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully fixes #3001, disables combination described in #5408
This now finally re-enables ELCIC for non-neutral systems. It turns out, that also the not yet disabled metallic case was also affected by #3001.
lzwith and without gap for the corrections, we had a jump in our energy.box_lengthinstead ofbox_h.const_potwas silently ignored by the code.