Skip to content

Fix regressions in the cell structure - #5406

Merged
jngrad merged 1 commit into
espressomd:pythonfrom
jngrad:cell_structure_fixes
Aug 3, 2026
Merged

Fix regressions in the cell structure#5406
jngrad merged 1 commit into
espressomd:pythonfrom
jngrad:cell_structure_fixes

Conversation

@jngrad

@jngrad jngrad commented Aug 3, 2026

Copy link
Copy Markdown
Member

Description of changes:

  • properly handle ghost particle edge case in the LB particle coupling code
    • since 5.0.0, ghost particles could accidentally still track a deleted particle during LB particle coupling
  • removed particles are now also removed from the cache
    • before, they would only be removed from the cache at the next particle resort
  • improve code coverage

jngrad
jngrad commented Aug 3, 2026
View reviewed changes
Comment thread src/core/unit_tests/BoxGeometry_test.cpp
@jngrad
jngrad marked this pull request as ready for review August 3, 2026 09:25
@jngrad
jngrad requested a review from itischler August 3, 2026 09:29
@jngrad jngrad added this to the ESPResSo 5.0.2 milestone Aug 3, 2026
@jngrad
jngrad merged commit da69666 into espressomd:python Aug 3, 2026
10 checks passed
@jngrad
jngrad deleted the cell_structure_fixes branch August 3, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itischler itischler itischler approved these changes

Assignees

No one assigned

Labels

BugFix Core

Projects

None yet

Milestone

ESPResSo 5.0.2

Development

Successfully merging this pull request may close these issues.

2 participants

@jngrad @itischler