Skip to content

Conversation

@roma-jam
Copy link
Collaborator

@roma-jam roma-jam commented Jan 21, 2025

Requirements

Latest release v1.7.0 breaks the example/network/sta2eth build on ESP32S2.
Reason: region `dram0_0_seg' overflowed by:

  • 1336 bytes (in my local build)
  • 2024 bytes (in the CI build)

To prevent same result in the future, add example to the CI with all available versions of esp-idf

Description

This is a 1/3 PR to fix the problem.

PR plan:

  1. Add all esp-idf releases to the current CI build process (this PR)
  2. Fix the NCM Driver memory usage on ESP32S2 (fix(ncm): Changed NTB default value to fix DRAM overflow on esp32s2 #125)
  3. Add network examples to the CI build process (ci(workflow): Add esp-idf network examples build #124)

Several PR's could be merged after completion in one (or not).

Related

N/A

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@roma-jam roma-jam self-assigned this Jan 21, 2025
@roma-jam roma-jam marked this pull request as ready for review January 21, 2025 09:40
@roma-jam roma-jam added this to the esp_tinyusb v1.7.1 milestone Jan 21, 2025
Copy link
Collaborator

@peter-marcisovsky peter-marcisovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the commit message say something like Added build for all esp-idf versions? Because you are not enabling build for all examples.

Otherwise LGTM.

@roma-jam roma-jam changed the title ci(workflow): Added build all esp-idf examples to ci ci(workflow): Added esp-idf releases matrix for examples build Jan 21, 2025
@roma-jam roma-jam merged commit 7898011 into master Jan 21, 2025
36 checks passed
@roma-jam roma-jam deleted the ci/build_all_esp_idf branch January 21, 2025 14:11
@roma-jam roma-jam mentioned this pull request Jan 21, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants