Skip to content

Conversation

KenVanHoeylandt
Copy link

@KenVanHoeylandt KenVanHoeylandt commented Sep 26, 2025

Description

Allow override of the symbol mapping functionality. See proposal for details.

I also included a small fix for C++ compilers that error out here:

#define ESP_ELFSYM_EXPORT(_sym) { #_sym, &_sym }

The solution was to cast explicitly:

#define ESP_ELFSYM_EXPORT(_sym) { #_sym, (void*)&_sym }

Related

Testing

Tested on LilyGo T-Deck Plus with ESP-IDF 5.5 installed on Linux with Intel 64-bit.

Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@CLAassistant
Copy link

CLAassistant commented Sep 26, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Sep 26, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello KenVanHoeylandt, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against b51121b

@github-actions github-actions bot changed the title Support alternative symbol resolving implementations for elf_loader Support alternative symbol resolving implementations for elf_loader (AEGHB-1243) Sep 26, 2025
@KenVanHoeylandt KenVanHoeylandt force-pushed the elf_loader_symbol_resolver branch from a304bcb to b51121b Compare September 26, 2025 22:03
@KenVanHoeylandt KenVanHoeylandt marked this pull request as ready for review September 26, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants