Skip to content

Conversation

@JakubAndrysek
Copy link
Collaborator

No description provided.

@JakubAndrysek
Copy link
Collaborator Author

Sorry, incorrect PR target.
I wanted to use my personal, but the default is Espressif

@github-actions
Copy link
Contributor

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "feat(ci): enhance CI workflow to cache and upload compiled binaries for improved build efficiency":
    • summary appears to be too long
  • the commit message "feat(docs): enhance example build script and CI workflow with diagram generation and updated requirements":
    • summary appears to be too long
  • the commit message "fix(docs): update esp-docs dependency to specific git reference and add debug flag for example builds":
    • summary appears to be too long
  • the commit message "refactor(ci): streamline Arduino CLI and ESP32 core installation in docs build workflow":
    • summary appears to be too long

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️ The Pull Request description is empty. Please provide a detailed description.

👋 Hello JakubAndrysek, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 0c98e04


def run_cmd(cmd, check=True, capture_output=False, text=True):
try:
return subprocess.run(cmd, check=check, capture_output=capture_output, text=text)

Check failure

Code scanning / CodeQL

Uncontrolled command line Critical

This command depends on
a user-provided value
.
This command depends on
a user-provided value
.
This command depends on
a user-provided value
.
This command depends on
a user-provided value
.
if not os.listdir(root):
try:
os.rmdir(root)
except Exception:

Check notice

Code scanning / CodeQL

Insufficient Logging Low

Try-catch except, Pass/Continue detected.
data = json.loads(ci_json.read_text())
if 'upload-binary' in data and data['upload-binary']:
res.append(str(ino))
except Exception:

Check notice

Code scanning / CodeQL

Insufficient Logging Low

Try-catch except, Pass/Continue detected.
@github-actions
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C5000.000.00000.000.00
ESP32P40⚠️ +240.00⚠️ +0.01000.000.00
ESP32S30⚠️ +320.00⚠️ +0.01000.000.00
ESP32S20⚠️ +240.00⚠️ +0.01000.000.00
ESP32C30⚠️ +240.00⚠️ +0.01000.000.00
ESP32C60⚠️ +240.00⚠️ +0.01000.000.00
ESP32H20⚠️ +240.00⚠️ +0.01000.000.00
ESP320⚠️ +320.00⚠️ +0.01000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C5ESP32P4ESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/BLE/examples/Server000000--00000000
libraries/ESP32/examples/GPIO/FunctionalInterrupt00⚠️ +240⚠️ +160⚠️ +240⚠️ +240⚠️ +240⚠️ +240⚠️ +320
libraries/ESP32/examples/GPIO/GPIOInterrupt00⚠️ +240⚠️ +320⚠️ +240⚠️ +240⚠️ +240⚠️ +240⚠️ +160
libraries/Insights/examples/MinimalDiagnostics00--00000000--00
libraries/NetworkClientSecure/examples/WiFiClientSecure000000000000--00
ESP32/examples/GPIO/FunctionalInterrupt (2)----------------
ESP32/examples/GPIO/FunctionalInterrupt (3)----------------
ESP32/examples/GPIO/FunctionalInterrupt (4)----------------
ESP32/examples/GPIO/GPIOInterrupt (2)----------------
ESP32/examples/GPIO/GPIOInterrupt (3)----------------
ESP32/examples/GPIO/GPIOInterrupt (4)----------------
libraries/ESP32/examples/Camera/CameraWebServer----0000------00
ESP32/examples/Camera/CameraWebServer (2)----0000------00
ESP32/examples/Camera/CameraWebServer (3)----00----------

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant