test: fix SupportBean capture assertions regardless of capture order#296
Open
lawrencewang49 wants to merge 1 commit intoespertechinc:masterfrom
Open
test: fix SupportBean capture assertions regardless of capture order#296lawrencewang49 wants to merge 1 commit intoespertechinc:masterfrom
lawrencewang49 wants to merge 1 commit intoespertechinc:masterfrom
Conversation
added back deleted line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a flaky test in the regression suite that failed nondeterministically under NonDex runs.
The test previously assumed a fixed ordering of captured SupportBean instances, which caused failures when the internal order varied.
Changes Made
SupportBeanobjects with specificintPrimitivevalues (10 and 11) rather than assuming they appear in a specific order withinDefaultSupportCaptureOpStatic.getInstances()as shown below:Reasoning
NonDex revealed that the original test relied on non-deterministic ordering of internal data structures.
By verifying the existence of expected values instead of positional order, the test now correctly validates functionality without being sensitive to iteration sequence.
Testing
Impact
Steps to Reproduce
mvn install -pl regression-run -am -DskipTestsmvn -fn -pl regression-run edu.illinois:nondex-maven-plugin:2.1.7:nondex -Dtest=com.espertech.esper.regressionrun.suite.epl.TestSuiteEPLDataflow -DnondexRuns=10, which should output the following: